This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
Separate extension install from pip install #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Borrow extensionapp.py from nbgrader to install / activate * Start separation of pip install from ext install (c) Copyright IBM Corp. 2016
(c) Copyright IBM Corp. 2016
(c) Copyright IBM Corp. 2016
(c) Copyright IBM Corp. 2016
(c) Copyright IBM Corp. 2016
parente
changed the title
(c) Copyright IBM Corp. 2016
(c) Copyright IBM Corp. 2016
This was referenced Jan 11, 2016
Properly installs top-level scripts as exes on Windows (c) Copyright IBM Corp. 2016
parente
added a commit
that referenced
this pull request
Jan 21, 2016
Separate extension install from pip install
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the current best practices for installing extensions on Jupyter 4.x:
Fixes #19
@lbustelo @jtyberg If we adopt this here, we have to adopt it everywhere (dashboards, declarativewidgets), because the JSON config file takes precedence over the .py config file for the server extensions list. (Keep in mind, we're already incompatible with extensions like nbgrader, nbpresent, ... which will clobber our hack-to-.py file config)